pouët.net

Good.

Why wouldn't it be ? That's what OSS and PRs are for ;)

[inner-monologue] 39 unique colours sound like way too many, but that's not surprising.I'd expect a 12-16 max. Also with CSS vars, it's trivial for people to theme, and add light/dark theme. [/inner-monologue]

Themes are cool, but...

Using Nectarine as an example (I did replicate a theme very much like that orange one, by request, based on pages found in the Internet Archive's Wayback Machine), the problem is that most people haven't a clue about CSS (or just don't care), and so it falls on a few people to write themes, which many then use... but they don't really ever get updated, even for small issues with stuff that never changes. They get frozen in time.

That said though... I'm not one to stand in the way of progress, and if you mean just allowing users to make color changes (not whole stylesheet overrides), that would be the least worst thing... but the defaults would be interesting seeing as the page background is a repeating image rather than a solid color.

(Though looking into it; it seems somebody, or Gargaj even, made the background image an SVG! so theoretically it could be given a transparent background and the trumpet a transparent black color replicating the existing darkening, so that it would work for light-enough background colors since CSS variables can't pierce a url()'d background to make it go lighter on dark backgrounds.)

So true :-)

- Signed, someone who implements CSS in browsers

Guilty!

BTW, I don't think full-on theming is really a good plan; heavily themeable sites tends to need pretty awful HTML, because the HTML and the CSS usually ends up being pretty strongly coupled. That's certainly the case for the CSS we have on Pouët right now.

...But doing a few color-themes variations might make sense. For instance, Pouët could really join the future and implement high-contrast, dark / light mode etc. And in that case we might also want a "traditionalist mode", for those people who can't stand changes ;)

And in either case cleaning up the CSS and avoiding repetitions by using CSS variables seems like a great plan simply for the maintainability.

Adding CSS variables is a small change, that won't realistically break anything (they are supported by every active rendering engine) and will enable those who care to tweak Pouet to their preferences.

(Please put all the variables on :root, once)

Amen

BTW, the CSS files, as well as most other assets, are not in the GitHub repo, for some bizarre reason.

While this isnt in the GitHub, I've made a preliminary version here:
https://gist.github.com/rc55/078442e7fe482b2b293c26218c4c1b6f

I haven't put a naming convention in just yet as some colours are used across different components (depending on the appetite there I could revise that).

For anyone wanting to play, you can use the StyleBot plugin for any modern browser - just cut and paste in the code into StyleBot.

These colours are used most often: 01, 24, 25 ,03 ,27, 09, 04, 26, 10, 11.

Feel free to share your horror, it's a new thing for me.

(also some colours can be deduplicated, I'm treading lightly).

var(--coulour-14)

smelly

rc55: Pouet seems to prefer US spelling, not UK. In other words, it should be "color" instead of "colour". I also think these shouldn't be numbered, but rather given some semantic values.

So IMO, more like this:

@kusma: thank you, I'll apply that and update it soon. :)